linux-kernel - Re: [PATCH] Blackfin: bf537: rename "CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52FCF2CD.9000008@roeck-us.net>
Date:	Thu, 13 Feb 2014 08:29:01 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Paul Bolle <pebolle@...cali.nl>,
	Lars-Peter Clausen <lars@...afoo.de>
CC:	Steven Miao <realmz6@...il.com>,
	adi-buildroot-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Blackfin: bf537: rename "CONFIG_ADT7310" and friends

On 02/13/2014 02:31 AM, Paul Bolle wrote:
> On Thu, 2014-02-13 at 10:57 +0100, Paul Bolle wrote:
>> This issue is still present in v3.14-rc2. Guenter's suggestion is the
>> easiest way out. Should I submit a trivial patch that just removes the
>> dead code depending on never defined CONFIG_ADT7310 and
>> CONFIG_ADT7310_MODULE?
>

My suggestion was to remove the ifdefs, not the code, and if I
understand the reply correctly that won't work because in that
case multiple devices would be registered with the SPI core
on the same SPI interface.

> And that is probably also true for for CONFIG_ADT7410 and
> CONFIG_ADT7410_MODULE. See https://lkml.org/lkml/2013/5/13/497 (and my
> follow up to that message).
>

Both Jean and myself sent Reviewed-by/Acked-by feedback.
Not being the maintainers, that is pretty much all we can do.
 From there it is really up to the maintainer to accept
or reject the patches.

Sure, we both suggested that the code is messy, but cleaning
that up would or should be a separate task anyway for someone
who has both the hardware and the time/interest to do it.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/