lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 Feb 2014 09:37:05 -0700 From: Stephen Warren <swarren@...dotorg.org> To: Tomasz Figa <t.figa@...sung.com>, Alexandre Courbot <acourbot@...dia.com>, Thierry Reding <thierry.reding@...il.com>, Russell King <linux@....linux.org.uk> CC: Olof Johansson <olof@...om.net>, linux-arm-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org, gnurou@...il.com Subject: Re: [PATCH v2 4/6] ARM: firmware: add prepare_idle() operation On 02/13/2014 04:01 AM, Tomasz Figa wrote: > Hi Alexandre, > > On 07.02.2014 05:35, Alexandre Courbot wrote: >> Some firmwares do not put the CPU into idle mode themselves, but still >> need to be informed that the CPU is about to enter idle mode before this >> happens. Add a prepare_idle() operation to the firmware_ops structure to >> handle such cases. >> >> Signed-off-by: Alexandre Courbot <acourbot@...dia.com> >> --- >> arch/arm/include/asm/firmware.h | 4 ++++ >> 1 file changed, 4 insertions(+) > > I wonder if .do_idle() couldn't simply return an appropriate error code > to let the upper layer know that it should proceed with normal CPU idle > activation, while still letting the firmware know that the CPU is going > to idle. That seems to disagree with the naming of the operation, and the semantics I assume it has, though. It seems clearer to add an explicit separate op for this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists