linux-kernel - [PATCH 03/08] PCI: rcar: fix bridge logic configuration accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140213030332.10398.67426.sendpatchset@w520>
Date:	Thu, 13 Feb 2014 12:03:32 +0900
From:	Magnus Damm <magnus.damm@...il.com>
To:	linux-pci@...r.kernel.org
Cc:	horms@...ge.net.au, linux-sh@...r.kernel.org,
	linux-kernel@...r.kernel.org, valentine.barshak@...entembedded.com,
	ben.dooks@...ethink.co.uk, geert@...ux-m68k.org,
	bhelgaas@...gle.com, Magnus Damm <magnus.damm@...il.com>
Subject: [PATCH 03/08] PCI: rcar: fix bridge logic configuration accesses

From: Ben Dooks <ben.dooks@...ethink.co.uk>

The bridge logic at slot 0 only supports reads up to 0x40 and the
rest of the PCI configuration space for this slot is marked as
reserved in the manual.

Trying a read from offset 0x100 is producing an error from the
bridge. With error interrupts enabled, the following is printed:

pci-rcar-gen2 ee0d0000.pci: error irq: status 00000014

Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
Signed-off-by: Magnus Damm <damm@...nsource.se>
---

 drivers/pci/host/pci-rcar-gen2.c |    4 ++++
 1 file changed, 4 insertions(+)

--- 0005/drivers/pci/host/pci-rcar-gen2.c
+++ work/drivers/pci/host/pci-rcar-gen2.c	2014-02-13 09:45:45.000000000 +0900
@@ -119,6 +119,10 @@ static void __iomem *rcar_pci_cfg_base(s
 	if (slot > 2)
 		return NULL;
 
+	/* bridge logic only has registers to 0x40 */
+	if (slot == 0x0 && where >= 0x40)
+		return NULL;
+
 	val = slot ? RCAR_AHBPCI_WIN1_DEVICE | RCAR_AHBPCI_WIN_CTR_CFG :
 		     RCAR_AHBPCI_WIN1_HOST | RCAR_AHBPCI_WIN_CTR_CFG;
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/