linux-kernel - Re: [PATCH] gpu:drm:tilcdc: backlight node never found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 14 Feb 2014 00:37:20 +0100
From:	Anatolij Gustschin <agust@...x.de>
To:	Heiko Schocher <hs@...x.de>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Benoit Parrot <bparrot@...com>,
	Rob Clark <robdclark@...il.com>,
	David Airlie <airlied@...ux.ie>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH] gpu:drm:tilcdc: backlight node never found

On Thu, 13 Feb 2014 14:47:38 +0100
Heiko Schocher <hs@...x.de> wrote:

> In panel_probe() the backlight node is never found, correct this.
> 
> Signed-off-by: Heiko Schocher <hs@...x.de>

Acked-by: Anatolij Gustschin <agust@...x.de>

> Cc: Anatolij Gustschin <agust@...x.de>
> Cc: Benoit Parrot <bparrot@...com>
> Cc: Rob Clark <robdclark@...il.com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Grant Likely <grant.likely@...aro.org>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Tomi Valkeinen <tomi.valkeinen@...com>
> Cc: Sachin Kamat <sachin.kamat@...aro.org>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: linux-kernel@...r.kernel.org
> Cc: devicetree@...r.kernel.org
> ---
>  drivers/gpu/drm/tilcdc/tilcdc_panel.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 86c6732..0b97cf4 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -356,6 +356,7 @@ static struct of_device_id panel_of_match[];
>  static int panel_probe(struct platform_device *pdev)
>  {
>  	struct device_node *node = pdev->dev.of_node;
> +	struct device_node *backlight_node;
>  	struct panel_module *panel_mod;
>  	struct tilcdc_module *mod;
>  	struct pinctrl *pinctrl;
> @@ -395,9 +396,15 @@ static int panel_probe(struct platform_device *pdev)
>  
>  	mod->preferred_bpp = panel_mod->info->bpp;
>  
> -	panel_mod->backlight = of_find_backlight_by_node(node);
> -	if (panel_mod->backlight)
> -		dev_info(&pdev->dev, "found backlight\n");
> +	backlight_node = of_parse_phandle(pdev->dev.of_node, "backlight", 0);
> +	if (backlight_node) {
> +		panel_mod->backlight =
> +			of_find_backlight_by_node(backlight_node);
> +		if (panel_mod->backlight)
> +			dev_info(&pdev->dev, "found backlight\n");
> +	} else {
> +		dev_warn(&pdev->dev, "backlight node missing...\n");
> +	}
>  
>  	return 0;
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/