linux-kernel - Re: [PATCH] ARM: DTS: exynos5420: Rename hsi2c compatible to exynos5250-hsi2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52FD57F2.8@samsung.com>
Date:	Fri, 14 Feb 2014 08:40:34 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	Naveen Krishna Chatradhi <ch.naveen@...sung.com>
CC:	linux-samsung-soc@...r.kernel.org, linux-i2c@...r.kernel.org,
	kgene.kim@...sung.com, devicetree-discuss@...ts.ozlabs.org,
	w.sang@...gutronix.de, balbi@...com, linux-kernel@...r.kernel.org,
	grant.likely@...retlab.ca, taeggyun.ko@...sung.com,
	cpgs@...sung.com, naveenkrishna.ch@...il.com, t.figa@...sung.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: DTS: exynos5420: Rename hsi2c compatible to exynos5250-hsi2c

On 02/06/14 21:07, Naveen Krishna Chatradhi wrote:
> As per the changes submitted for the i2c-exynos5.c driver with the
> compatible string being named after the first SoC it is observed on.
> This patch modifes the existing hsi2c compatible strings in
> arch/arm/boot/dts.
>
> Signed-off-by: Naveen Krishna Chatradhi<ch.naveen@...sung.com>
> ---
>   arch/arm/boot/dts/exynos5420.dtsi |   14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 11dd202..c5187d1 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -486,7 +486,7 @@
>   	};
>
>   	hsi2c_4: i2c@...A0000 {
> -		compatible = "samsung,exynos5-hsi2c";
> +		compatible = "samsung,exynos5250-hsi2c";
>   		reg =<0x12CA0000 0x1000>;
>   		interrupts =<0 60 0>;
>   		#address-cells =<1>;
> @@ -499,7 +499,7 @@
>   	};
>
>   	hsi2c_5: i2c@...B0000 {
> -		compatible = "samsung,exynos5-hsi2c";
> +		compatible = "samsung,exynos5250-hsi2c";
>   		reg =<0x12CB0000 0x1000>;
>   		interrupts =<0 61 0>;
>   		#address-cells =<1>;
> @@ -512,7 +512,7 @@
>   	};
>
>   	hsi2c_6: i2c@...C0000 {
> -		compatible = "samsung,exynos5-hsi2c";
> +		compatible = "samsung,exynos5250-hsi2c";
>   		reg =<0x12CC0000 0x1000>;
>   		interrupts =<0 62 0>;
>   		#address-cells =<1>;
> @@ -525,7 +525,7 @@
>   	};
>
>   	hsi2c_7: i2c@...D0000 {
> -		compatible = "samsung,exynos5-hsi2c";
> +		compatible = "samsung,exynos5250-hsi2c";
>   		reg =<0x12CD0000 0x1000>;
>   		interrupts =<0 63 0>;
>   		#address-cells =<1>;
> @@ -538,7 +538,7 @@
>   	};
>
>   	hsi2c_8: i2c@...00000 {
> -		compatible = "samsung,exynos5-hsi2c";
> +		compatible = "samsung,exynos5250-hsi2c";
>   		reg =<0x12E00000 0x1000>;
>   		interrupts =<0 87 0>;
>   		#address-cells =<1>;
> @@ -551,7 +551,7 @@
>   	};
>
>   	hsi2c_9: i2c@...10000 {
> -		compatible = "samsung,exynos5-hsi2c";
> +		compatible = "samsung,exynos5250-hsi2c";
>   		reg =<0x12E10000 0x1000>;
>   		interrupts =<0 88 0>;
>   		#address-cells =<1>;
> @@ -564,7 +564,7 @@
>   	};
>
>   	hsi2c_10: i2c@...20000 {
> -		compatible = "samsung,exynos5-hsi2c";
> +		compatible = "samsung,exynos5250-hsi2c";
>   		reg =<0x12E20000 0x1000>;
>   		interrupts =<0 203 0>;
>   		#address-cells =<1>;

Naveen,

Please don't post separately for one series. It's hard to find to look 
at regarding patches.

And please post regarding binding doc together. Additionally if you run 
checkpatch, you can see see below complaining.

"WARNING: DT compatible string "samsung,exynos5250-hsi2c" appears 
un-documented -- check ./Documentation/devicetree/bindings/"

- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/