linux-kernel - Re: [PATCH v15 0/10] Add 32 bit VDSO time function support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52FDCAB0.2090509@zytor.com>
Date:	Thu, 13 Feb 2014 23:50:08 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Stefani Seibold <stefani@...bold.net>
CC:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	x86@...nel.org, tglx@...utronix.de, mingo@...hat.com,
	ak@...ux.intel.com, aarcange@...hat.com, john.stultz@...aro.org,
	luto@...capital.net, xemul@...allels.com, gorcunov@...nvz.org,
	andriy.shevchenko@...ux.intel.com, Martin.Runge@...de-schwarz.com,
	Andreas.Brief@...de-schwarz.com
Subject: Re: [PATCH v15 0/10] Add 32 bit VDSO time function support

On 02/13/2014 11:48 PM, Stefani Seibold wrote:
> Am Donnerstag, den 13.02.2014, 22:47 -0800 schrieb H. Peter Anvin:
>> Hi,
>>
>> I tried this patchset, but it fails to compile on i386 "make allyesconfig".
>>
>> 	-hpa
>>
> 
> I tried "make allyseconfig" on my i386, but the resulting config will
> always set CONFIG_X86_64=y, so it fails with

"make ARCH=i386 allyesconfig"

... will do it for you.

> scripts/mod/empty.c:1:0: error: CPU you selected does not support x86-64
> instruction set
> 
> Setting to CONFIG_X86_32 by hand will allow to compile but fails in
> vclock_gettime.c, because CONFIG_PARAVIRT_CLOCK is not supported for by
> a 32 bit VDSO.

Right, this is the problem here.  Keep in mind many shipping kernels
will have CONFIG_PARAVIRT_CLOCK enabled, so it matters that a PV kernel
*booting native* doesn't take an unnecessary hit.

> PARAVIRT_CLOCK and getcpu is an other topic which is not addressed by
> this patch set.
> 
> I will do a patch to fix this.

Thanks.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/