linux-kernel - Re: [PATCH] vt: Fix secure clear screen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140214103929.GA3933@amd.pavel.ucw.cz>
Date:	Fri, 14 Feb 2014 11:39:30 +0100
From:	Pavel Machek <pavel@....cz>
To:	Petr Písař <petr.pisar@...as.cz>
Cc:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jean-François Moine <moinejf@...e.fr>
Subject: Re: [PATCH] vt: Fix secure clear screen

Hi!

> \E[3J console code (secure clear screen) needs to update_screen(vc)
> in order to write-through blanks into off-screen video memory.

I guess it is also suitable for stable, right?

Thanks,
								Pavel

> This has been removed accidentally in 3.6 by:
> 
> commit 81732c3b2fede049a692e58a7ceabb6d18ffb18c
> Author: Jean-François Moine <moinejf@...e.fr>
> Date:   Thu Sep 6 19:24:13 2012 +0200
> 
>     tty vt: Fix line garbage in virtual console on command line edition
> 
> Signed-off-by: Petr Písař <petr.pisar@...as.cz>
> ---
>  drivers/tty/vt/vt.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index 61b1137..23b5d32 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -1164,6 +1164,8 @@ static void csi_J(struct vc_data *vc, int vpar)
>  			scr_memsetw(vc->vc_screenbuf, vc->vc_video_erase_char,
>  				    vc->vc_screenbuf_size >> 1);
>  			set_origin(vc);
> +			if (CON_IS_VISIBLE(vc))
> +				update_screen(vc);
>  			/* fall through */
>  		case 2: /* erase whole display */
>  			count = vc->vc_cols * vc->vc_rows;

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/