linux-kernel - Re: [PATCH V2 2/2] mm/vmscan: not check compaction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140214110446.GB6732@suse.de>
Date:	Fri, 14 Feb 2014 11:04:46 +0000
From:	Mel Gorman <mgorman@...e.de>
To:	Weijie Yang <weijie.yang@...sung.com>
Cc:	'Andrew Morton' <akpm@...ux-foundation.org>, riel@...hat.com,
	'Minchan Kim' <minchan@...nel.org>, weijie.yang.kh@...il.com,
	'Linux-MM' <linux-mm@...ck.org>,
	'linux-kernel' <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 2/2] mm/vmscan: not check compaction_ready on promoted
 zones

On Fri, Feb 14, 2014 at 02:42:34PM +0800, Weijie Yang wrote:
> We abort direct reclaim if find the zone is ready for compaction.
> Sometimes the zone is just a promoted highmem zone to force scan
> pinning highmem, which is not the intended zone the caller want to
> alloc page from. In this situation, setting aborted_reclaim to
> indicate the caller turn back to retry allocation is waste of time
> and could cause a loop in __alloc_pages_slowpath().
> 
> This patch do not check compaction_ready() on promoted zones to avoid
> the above situation, only set aborted_reclaim if the caller intended
> zone is ready to compaction.
> 
> Acked-by: Rik van Riel <riel@...hat.com>
> Signed-off-by: Weijie Yang <weijie.yang@...sung.com>

Acked-by: Mel Gorman <mgorman@...e.de>

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/