linux-kernel - Re: [PATCH RFC 2/3] fbdev: move fbdev core files to separate directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Feb 2014 13:27:13 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Tomi Valkeinen <tomi.valkeinen@...com>
Cc:	Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
	DRI Development <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	David Airlie <airlied@...ux.ie>
Subject: Re: [PATCH RFC 2/3] fbdev: move fbdev core files to separate directory

Hi Tomi,

Thanks for doing this!

Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

On Fri, Feb 14, 2014 at 12:18 PM, Tomi Valkeinen <tomi.valkeinen@...com> wrote:
> --- a/drivers/video/fbdev/fbmon.c
> +++ b/drivers/video/fbdev/core/fbmon.c
> @@ -37,7 +37,7 @@
>  #include <asm/prom.h>
>  #include <asm/>
>  /*
>   * EDID parserpci-bridge.h>
>  #endif
> -#include "edid.h"
> +#include "../edid.h"

This looks a bit asymmetrical ...

> --- a/drivers/video/fbdev/wmt_ge_rops.c
> +++ b/drivers/video/fbdev/wmt_ge_rops.c
> @@ -18,7 +18,7 @@
>  #include <linux/module.h>
>  #include <linux/fb.h>
>  #include <linux/platform_device.h>
> -#include "fb_draw.h"
> +#include "core/fb_draw.h"

... to this.

Perhaps (the content of) edid.h belongs in include/video/edid.h?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/