linux-kernel - Re: [PATCH ] workqueue: add args to workqueue lockdep name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140214140613.GA29516@htj.dyndns.org>
Date:	Fri, 14 Feb 2014 09:06:13 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Li Zhong <zhong@...ux.vnet.ibm.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Tommi Rantala <tt.rantala@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Dave Jones <davej@...hat.com>, trinity@...r.kernel.org
Subject: Re: [PATCH ] workqueue: add args to workqueue lockdep name

On Fri, Feb 14, 2014 at 10:52:57AM +0800, Li Zhong wrote:
> Tommi noticed a 'funny' lock class name: "%s#5" from a lock acquired in
> process_one_work().
> 
> Maybe #fmt plus #args could be used as the lock_name to give some more
> information for some fmt string like the above. 
> 
> __builtin_constant_p() check is removed (as there seems no good way to
> check all the variables in args list). However, by removing the check,
> it only adds two additional "s for those constants.
> 
> Some lockdep name examples printed out after the change:
> 
> lockdep name                    wq->name
> 
> "events_long"                   events_long
> "%s"("khelper")                 khelper
> "xfs-data/%s"mp->m_fsname       xfs-data/dm-3
> 
> Signed-off-by: Li Zhong <zhong@...ux.vnet.ibm.com>

Applied to wq/for-3.14-fixes.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/