| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140214165019.GI31544@htj.dyndns.org> Date: Fri, 14 Feb 2014 11:50:19 -0500 From: Tejun Heo <tj@...nel.org> To: Li Zefan <lizefan@...wei.com> Cc: cgroups@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH cgroup/for-3.14-fixes] cgroup: update cgroup_enable_task_cg_lists() to grab siglock Hello, On Fri, Feb 14, 2014 at 11:49:42AM +0800, Li Zefan wrote: > Now the only race I see is caused by checking tsk->cg_list without locking > in cgroup_exit(): Yeah, that's the one I was trying to fix. > Your patch can fix this race, but after diving into the code I don't think > the race exists, because exit_mm() locks&unlocks task_lock, and exit_mm() > is called after exit_signal() and before cgroup_exit(), and task_lock is > also taken by cgroup_enable_task_cg_lists(). Ah, okay, so there's a task_lock somewhere in the exit path. Extremely fragile, but not broken. > I totally agree the code is fragile and we should take your patch. I just > want to make it clear if the bug exists in real life or not, and then we > can write better changelog and decide to queue the patch for 3.14 or 3.15 > and decide to mark it for stable or not. Yeap, no reason to mark it for -stable if it doesn't actually happen. I'll update the description and respin it for for-3.15. Thanks! -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists