| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Feb 2014 15:06:40 +0000
From: Mark Brown <broonie@...nel.org>
To: "Ivan T. Ivanov" <iivanov@...sol.com>
Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: core: Validate lenght of the transfers in message
On Thu, Feb 13, 2014 at 04:46:46PM +0200, Ivan T. Ivanov wrote:
> + /* No partial transfers accepted */
> + if (!n_words || xfer->len & (w_size - 1))
> + return -EINVAL;
Please write this using % rather than the & - it's a lot clearer what
it's checking for, I had to think what the above meant. Hopefully the
compiler will make it equally fast either way.
Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)
Powered by blists - more mailing lists