linux-kernel - Re: [PATCH v2 51/52] net/core/flow.c: Fix CPU hotplug callback registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140214.133128.1668791415154760386.davem@davemloft.net>
Date:	Fri, 14 Feb 2014 13:31:28 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	srivatsa.bhat@...ux.vnet.ibm.com
Cc:	paulus@...ba.org, oleg@...hat.com, mingo@...nel.org,
	rusty@...tcorp.com.au, peterz@...radead.org, tglx@...utronix.de,
	akpm@...ux-foundation.org, paulmck@...ux.vnet.ibm.com,
	tj@...nel.org, walken@...gle.com, ego@...ux.vnet.ibm.com,
	linux@....linux.org.uk, rjw@...ysocki.net,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	roy.qing.li@...il.com, sasha.levin@...cle.com, cmetcalf@...era.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2 51/52] net/core/flow.c: Fix CPU hotplug callback
 registration

From: "Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
Date: Fri, 14 Feb 2014 13:30:43 +0530

> Subsystems that want to register CPU hotplug callbacks, as well as perform
> initialization for the CPUs that are already online, often do it as shown
> below:
 ...
> This is wrong, since it is prone to ABBA deadlocks involving the
> cpu_add_remove_lock and the cpu_hotplug.lock (when running concurrently
> with CPU hotplug operations).
> 
> Instead, the correct and race-free way of performing the callback
> registration is:
 ...
> Fix the code in net/core/flow.c by using this latter form of callback
> registration.
> 
> Cc: Li RongQing <roy.qing.li@...il.com>
> Cc: Sasha Levin <sasha.levin@...cle.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Chris Metcalf <cmetcalf@...era.com>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: netdev@...r.kernel.org
> Signed-off-by: David S. Miller <davem@...emloft.net>
> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@...ux.vnet.ibm.com>

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/