linux-kernel - Re: [PATCH Resend] net: asix: add missing flag to struct driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140214.154853.1291869116525546930.davem@davemloft.net>
Date:	Fri, 14 Feb 2014 15:48:53 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	emilgoode@...il.com
Cc:	ming.lei@...onical.com, broonie@...aro.org,
	jeffrey.t.kirsher@...el.com, gdt@....id.au,
	linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH Resend] net: asix: add missing flag to struct
 driver_info

From: Emil Goode <emilgoode@...il.com>
Date: Thu, 13 Feb 2014 19:30:39 +0100

> The struct driver_info ax88178_info is assigned the function
> asix_rx_fixup_common as it's rx_fixup callback. This means that
> FLAG_MULTI_PACKET must be set as this function is cloning the
> data and calling usbnet_skb_return. Not setting this flag leads
> to usbnet_skb_return beeing called a second time from within
> the rx_process function in the usbnet module.
> 
> Signed-off-by: Emil Goode <emilgoode@...il.com>
> Reported-by: Bjørn Mork <bjorn@...k.no>

Applied and queued up for -stable.

It would be great if there were some way to validate these
callback flags requirements and catch such errors.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/