linux-kernel - Re: [PATCH] hwmon: (ntc_thermistor): Avoid overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52FD84A6.9000400@roeck-us.net>
Date:	Thu, 13 Feb 2014 18:51:18 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Doug Anderson <dianders@...omium.org>,
	Jean Delvare <jdelvare@...e.de>
CC:	lm-sensors@...sensors.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (ntc_thermistor): Avoid overflow

On 02/13/2014 02:39 PM, Doug Anderson wrote:
> The ntc thermistor code was doing math whose temporary result might
> have overflowed 32-bits.  We need some casts in there to make it safe.
>
> In one example I found:
> - pullup_uV: 1800000
> - result of iio_read_channel_raw: 3226
> - 1800000 * 3226 => 0x15a1cbc80
>
> Signed-off-by: Doug Anderson <dianders@...omium.org>

Nice catch. Applied.

Thanks,
Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/