linux-kernel - Re: [PATCH] [RFC] staging: rtl8821ae: fix invalid bit mask on MSR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140214220041.GD26722@mwanda>
Date:	Sat, 15 Feb 2014 01:00:41 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Levente Kurusa <levex@...ux.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	OSUOSL Drivers <devel@...verdev.osuosl.org>
Subject: Re: [PATCH] [RFC] staging: rtl8821ae: fix invalid bit mask on MSR_AP
 check

On Fri, Feb 14, 2014 at 10:50:23PM +0100, Levente Kurusa wrote:
> Since MSR_AP is 0x3, ANDing it with 0xFC will never be true.
> Add a NOT operation to 0xFC so that we will AND with the last
> three bits which will result in a possibility that the condition
> will succeed.
> 
> Signed-off-by: Levente Kurusa <levex@...ux.com>
> ---
>  Hi,
> 
>  This might not be the real solution since it is also possible that
>  the particular condition never really happens. I seek comments
>  so that I can post the proper patch.
> 

I can't test it either but I think your fix is correct.

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/