linux-kernel - Re: [PATCH] spi: core: Validate lenght of the transfers in message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140214002627.GG28112@sirena.org.uk>
Date:	Fri, 14 Feb 2014 00:26:27 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Gerhard Sittig <gsi@...x.de>
Cc:	"Ivan T. Ivanov" <iivanov@...sol.com>, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: core: Validate lenght of the transfers in message

On Thu, Feb 13, 2014 at 10:27:57PM +0100, Gerhard Sittig wrote:
> On Thu, Feb 13, 2014 at 16:46 +0200, Ivan T. Ivanov wrote:

> > SPI transfer lenght should be a power-of-two multiple
> > of eight bits.

> Are you suggesting that an SPI transfer cannot consist of e.g.
> three bytes?  This would be surprising, and certainly would be
> rather wrong an assumption.  Am I missing/misunderstanding
> something?

The check is supposed to be verifying that the transfer is a whole
number of the current SPI word size as I understand it (not actually
looked at the change yet but that's where it came from, factored out of
a driver).

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)