lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 15 Feb 2014 00:47:41 +0100 From: Pavel Machek <pavel@....cz> To: Sebastian Capella <sebastian.capella@...aro.org> Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, linaro-kernel@...ts.linaro.org, Len Brown <len.brown@...el.com>, "Rafael J. Wysocki" <rjw@...ysocki.net> Subject: Re: [PATCH v9] PM / Hibernate: use name_to_dev_t to parse resume Hi! > Use the name_to_dev_t call to parse the device name echo'd to > to /sys/power/resume. This imitates the method used in hibernate.c > in software_resume, and allows the resume partition to be specified > using other equivalent device formats as well. By allowing > /sys/debug/resume to accept the same syntax as the resume=device > parameter, we can parse the resume=device in the init script and > use the resume device directly from the kernel command line. > > Signed-off-by: Sebastian Capella <sebastian.capella@...aro.org> > Cc: Len Brown <len.brown@...el.com> > Cc: Pavel Machek <pavel@....cz> > Cc: "Rafael J. Wysocki" <rjw@...ysocki.net> Acked-by: Pavel Machek <pavel@....cz> > @@ -972,16 +972,20 @@ static ssize_t resume_show(struct kobject *kobj, struct kobj_attribute *attr, > static ssize_t resume_store(struct kobject *kobj, struct kobj_attribute *attr, > const char *buf, size_t n) > { > - unsigned int maj, min; > dev_t res; > - int ret = -EINVAL; > + int len = n; > + char *name; > > - if (sscanf(buf, "%u:%u", &maj, &min) != 2) > - goto out; > + if (len && buf[len-1] == '\n') > + len--; > + name = kstrndup(buf, len, GFP_KERNEL); > + if (!name) > + return -ENOMEM; And yes, it seems to do right thing even if "\n" is passed to it. > - res = MKDEV(maj,min); > - if (maj != MAJOR(res) || min != MINOR(res)) > - goto out; > + res = name_to_dev_t(name); > + kfree(name); -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists