linux-kernel - Re: [PATCH] staging: rts5208: fix always true condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140215104117.GF26722@mwanda>
Date:	Sat, 15 Feb 2014 13:41:17 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Levente Kurusa <levex@...ux.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Micky Ching <micky_ching@...lsil.com.cn>,
	OSUOSL Drivers <devel@...verdev.osuosl.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Binderman <dcb314@...mail.com>
Subject: Re: [PATCH] staging: rts5208: fix always true condition

On Sat, Feb 15, 2014 at 10:44:35AM +0100, Levente Kurusa wrote:
> ANDing anything with 0x1E and expecting it to be not 0x03 will always
> be true. AND instead with 0x03, so that we check the last two bits,
> which should be what was intended there.
> 

This one is less clear what the intent was.  Could easily be that the
0x3 is wrong.

Sometimes it's better to leave the warning rather than guess at the fix.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/