linux-kernel - Re: [PATCH] i2c: designware-pci: Add Baytrail PCI IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140215152736.GF2579@katana>
Date:	Sat, 15 Feb 2014 16:27:37 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	linux-i2c@...r.kernel.org,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: designware-pci: Add Baytrail PCI IDs

On Tue, Feb 04, 2014 at 04:31:19PM +0200, Mika Westerberg wrote:
> Intel Baytrail I2C controllers can be enumerated from PCI as well as from
> ACPI. In order to support this add the Baytrail PCI IDs to the driver.
> 
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Basically fine, one question:

> -	snprintf(adap->name, sizeof(adap->name), "i2c-designware-pci-%d",
> -		adap->nr);
> +
> +	if (adap->nr < 0)
> +		snprintf(adap->name, sizeof(adap->name), "i2c-designware-pci");
> +	else
> +		snprintf(adap->name, sizeof(adap->name),
> +			 "i2c-designware-pci-%d", adap->nr);

Maybe we just drop the "-%d" suffix entirely?


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)