linux-kernel - Re: [PATCH 19/73] arm: mach-s3c64xx mach-crag6410-module.c is not modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 16 Feb 2014 02:04:00 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
CC:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	linux-arch@...r.kernel.org, Kukjin Kim <kgene.kim@...sung.com>,
	Russell King <linux@....linux.org.uk>,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org,
	Ben Dooks <ben-linux@...ff.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 19/73] arm: mach-s3c64xx mach-crag6410-module.c is not
 modular

On 01/23/14 22:16, Charles Keepax wrote:
> On Tue, Jan 21, 2014 at 04:22:22PM -0500, Paul Gortmaker wrote:
>> Despite the name mach-crag6410-module.c, the code is built for
>> MACH_WLF_CRAGG_6410 -- which is bool, and hence this code is
>> either present or absent.  It will never be modular, so using
>> module_init as an alias for __initcall can be somewhat
>> misleading.
>>
>> Fix this up now, so that we can relocate module_init from
>> init.h into module.h in the future.  If we don't do this, we'd
>> have to add module.h to obviously non-modular code, and that
>> would be a worse thing.
>>
>> Note that direct use of __initcall is discouraged, vs. one
>> of the priority categorized subgroups.  As __initcall gets
>> mapped onto device_initcall, our use of device_initcall
>> directly in this change means that the runtime impact is
>> zero -- it will remain at level 6 in initcall ordering.
>>
>> Cc: Ben Dooks<ben-linux@...ff.org>
>> Cc: Kukjin Kim<kgene.kim@...sung.com>
>> Cc: Russell King<linux@....linux.org.uk>
>> Cc: patches@...nsource.wolfsonmicro.com
>> Cc: linux-arm-kernel@...ts.infradead.org
>> Signed-off-by: Paul Gortmaker<paul.gortmaker@...driver.com>
>> ---
>
> Tested-by: Charles Keepax<ckeepax@...nsource.wolfsonmicro.com>
>
Thanks, applied.

- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/