[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1392488030.4298.5.camel@jlt4.sipsolutions.net>
Date: Sat, 15 Feb 2014 19:13:50 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Justin van Wijngaarden <justinvanwijngaarden@...il.com>
Cc: linville@...driver.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH] Drivers: net: wireless: mac80211_hwim fixed coding
style issues
On Sat, 2014-02-15 at 12:55 +0100, Justin van Wijngaarden wrote:
> @@ -1,19 +1,17 @@
> -/*
> - * mac80211_hwsim - software simulator of 802.11 radio(s) for mac80211
> +/* mac80211_hwsim - software simulator of 802.11 radio(s) for mac80211
I don't see any point in this - lots of code exists both ways, that's
really just fluff. The difference isn't even interesting enough to be
worth fixing up.
> * published by the Free Software Foundation.
> - */
> +*/
That's just wrong.
In any case, your patch won't apply anyway since we've since
changed/removed code that you're modifying.
There's very little in this patch that I'd be willing to apply, and most
of that you actually got the coding style wrong so it's not an
improvement at all.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists