linux-kernel - Re: [PATCH 14/19] Kbuild, lto: Handle basic LTO in modpost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 15 Feb 2014 22:35:45 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org,
	linux-kbuild@...r.kernel.org, mmarek@...e.cz,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 14/19] Kbuild, lto: Handle basic LTO in modpost

On Fri, Feb 14, 2014 at 10:21:38PM +0100, Andi Kleen wrote:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> - Don't warn about LTO marker symbols. modpost runs before
> the linker, so the module is not necessarily LTOed yet.
> - Don't complain about .gnu.lto* sections
> 
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> ---
>  scripts/mod/modpost.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index f91dd45..63804a1 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -623,7 +623,10 @@ static void handle_modversions(struct module *mod, struct elf_info *info,
>  
>  	switch (sym->st_shndx) {
>  	case SHN_COMMON:
> -		warn("\"%s\" [%s] is COMMON symbol\n", symname, mod->name);
> +		if (!strncmp(symname, "__gnu_lto_", sizeof("__gnu_lto_")-1)) {

Please use space around "-".

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/