[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1392444566-23605-1-git-send-email-iivanov@mm-sol.com>
Date: Sat, 15 Feb 2014 08:09:26 +0200
From: "Ivan T. Ivanov" <iivanov@...sol.com>
To: Mark Brown <broonie@...nel.org>
Cc: "Ivan T. Ivanov" <iivanov@...sol.com>, linux-spi@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH v2] spi: core: Validate lenght of the transfers in message
From: "Ivan T. Ivanov" <iivanov@...sol.com>
SPI transfer lenght should be a power-of-two multiple
of eight bits.
Signed-off-by: Ivan T. Ivanov <iivanov@...sol.com>
---
drivers/spi/spi.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index d0b28bb..9bed365 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -1617,6 +1617,7 @@ static int __spi_validate(struct spi_device *spi, struct spi_message *message)
{
struct spi_master *master = spi->master;
struct spi_transfer *xfer;
+ int w_size, n_words;
if (list_empty(&message->transfers))
return -EINVAL;
@@ -1668,6 +1669,22 @@ static int __spi_validate(struct spi_device *spi, struct spi_message *message)
return -EINVAL;
}
+ /*
+ * SPI transfer length should be multiple of SPI word size
+ * where SPI word size should be power-of-two multiple
+ */
+ if (xfer->bits_per_word <= 8)
+ w_size = 1;
+ else if (xfer->bits_per_word <= 16)
+ w_size = 2;
+ else
+ w_size = 4;
+
+ n_words = xfer->len / w_size;
+ /* No partial transfers accepted */
+ if (!n_words || xfer->len % xfer->bits_per_word)
+ return -EINVAL;
+
if (xfer->speed_hz && master->min_speed_hz &&
xfer->speed_hz < master->min_speed_hz)
return -EINVAL;
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists