linux-kernel - Re: [PATCH 1/2] usb: host: remove USB_ARCH_HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 16 Feb 2014 21:11:09 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arnd Bergmann <arnd@...db.de>,
	Richard Weinberger <richard@....at>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] usb: host: remove USB_ARCH_HAS_?HCI

On Sun, 2014-02-16 at 15:02 -0500, Alan Stern wrote:
> On Sun, 16 Feb 2014, Paul Bolle wrote:
> > Note that the comment in this Kconfig file (that is also removed)
> > suggests to first remove the select statements for these symbols and
> > then the symbols themselves. But I think it makes more sense to first
> > delete these three symbols and then remove the selects statements (as
> > that is removing a second order effect). But it could just as well be
> > done with just one patch, I'd say.
> 
> There's a simple reason for not getting rid of the symbols first.  
> Doing it that way, as you did, leaves a window in which it's possible
> to select a non-existent symbol.  If that's not an error, it ought to
> be.

It is silently ignored. I've contemplated diving in the kconfig code to
see whether doing that could be made to trigger an error or, perhaps
better, a warning. I've not made up my mind yet.

It's trivial to merge these two patches, though. So feel free to ask me
to do that.

> Regardless, for both patches:
> 
> Acked-by: Alan Stern <stern@...land.harvard.edu>

Thanks.


Paul Bolle


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/