linux-kernel - Re: [PATCH] arm: imx: remove MACH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 16 Feb 2014 23:06:55 +0400
From:	Alexander Shiyan <shc_work@...l.ru>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Russell King <linux@....linux.org.uk>,
	Richard Weinberger <richard@....at>,
	linux-kernel@...r.kernel.org,
	Sascha Hauer <kernel@...gutronix.de>,
	Shawn Guo <shawn.guo@...aro.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm: imx: remove MACH_MXLADS

Воскресенье, 16 февраля 2014, 19:43 +01:00 от Paul Bolle <pebolle@...cali.nl>:
> On Sun, 2014-02-16 at 22:16 +0400, Alexander Shiyan wrote:
> > Воскресенье, 16 февраля 2014, 19:03 +01:00 от Paul Bolle
> <pebolle@...cali.nl>:
> > > The Kconfig symbol MACH_MXLADS was added in v2.6.29. It has never been
> > > used. Setting it has no effect. There are no calls for
> > > machine_is_mxlads(). This symbol can safely be removed.
> > > 
> > > Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> > 
> > This is used by mach-mx1ads.c
> 
> How is it used?

Kconfig selects MACH_MXLADS, this enables machine_arch_type
from include/generated/mach-types.h which used for machine_is_xx() macro,
so if multiple boards is defined in the kernel, this cause to incorrect matching.
Russel, Arnd, fixme.

---