linux-kernel - Re: [tip:x86/vdso] x86, vdso: Instead of dummy functions, include < linux/spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5301D615.8090907@zytor.com>
Date:	Mon, 17 Feb 2014 01:27:49 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Stefani Seibold <stefani@...bold.net>
CC:	mingo@...nel.org, linux-kernel@...r.kernel.org, tglx@...utronix.de,
	hpa@...ux.intel.com, linux-tip-commits@...r.kernel.org,
	Andy Lutomirski <luto@...capital.net>
Subject: Re: [tip:x86/vdso] x86, vdso: Instead of dummy functions, include
 < linux/spinlock_up.h>

On 02/16/2014 11:42 PM, Stefani Seibold wrote:
> I think for the first time it will be okay to kick out the
> _ASM_X86_SPINLOCK_H hack and accept the C=1 warnings.
>
> At next step it is necessary to make the whole BUILD_VDSO32 path in
> vclock_gettime.c independent from the kernel headers, only uapi/ should
> be included.
>
> The use of cycle_t must be replaced with u64.
>
> We need a own copy of __native_read_tsc(), __iter_div_u64_rem, smp_rmb()
> and cpu_relax().

All of which are quite trivial.

> For the non BUILD_VDSO32 path we must only move the #includes inside
> this #ifndef BUILD_VDSO32

Sorry, didn't quite follow that.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/