linux-kernel - Re: [PATCH] xen: remove XEN_PRIVILEGED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <201402171223.s1HCNG0S023567@userz7022.oracle.com>
Date:	Mon, 17 Feb 2014 07:23:13 -0500
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	x86@...nel.org, Thomas Gleixner <tglx@...utronix.de>,
	Richard Weinberger <richard@....at>,
	Michael Opdenacker <michael.opdenacker@...e-electrons.com>,
	Ingo Molnar <mingo@...hat.com>, xen-devel@...ts.xenproject.org,
	"H. Peter Anvin" <hpa@...or.com>,
	David Vrabel <david.vrabel@...rix.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xen: remove XEN_PRIVILEGED_GUEST


On Feb 16, 2014 3:07 PM, Paul Bolle <pebolle@...cali.nl> wrote:
>
> This patch removes the Kconfig symbol XEN_PRIVILEGED_GUEST which is 
> used nowhere in the tree. We do know grub2 has a script that greps 
> kernel configuration files for this symbol. It shouldn't do that. As

Please look in the grub git tree. They have fixed their code to not do this anymore. This should be reflected in the patch description.

Lastly please check which distro has this new grub version so that we know which distros won't be affected.

Thanks.

> Linus summarized: 
>     This is a grub bug. It really is that simple. Treat it as one. 
>
> So there's no reason to not remove it, like we do with all unused 
> Kconfig symbols. 
>
> [pebolle@...cali.nl: rewrote commit explanation.] 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@...e-electrons.com> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl> 
> --- 
> Tested with "git grep". 
>
> Michael's version can be found at https://lkml.org/lkml/2013/7/8/34 . 
> (This is the same patch, with a rewritten explanation, and my S-o-b 
> line.) The question whether this symbol can be removed was further 
> discussed in https://lkml.org/lkml/2013/7/15/308 . 
>
> I don't think a bug was ever filed against grub2 regarding its way to 
> check for Xen support. Should that be done first?

Had been done the moment I got Linus reply but instead of a bug it was on the mailing list.
>
> arch/x86/xen/Kconfig | 5 ----- 
> 1 file changed, 5 deletions(-) 
>
> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig 
> index 01b9026..512219d 100644 
> --- a/arch/x86/xen/Kconfig 
> +++ b/arch/x86/xen/Kconfig 
> @@ -19,11 +19,6 @@ config XEN_DOM0 
> depends on XEN && PCI_XEN && SWIOTLB_XEN 
> depends on X86_LOCAL_APIC && X86_IO_APIC && ACPI && PCI 
>
> -# Dummy symbol since people have come to rely on the PRIVILEGED_GUEST 
> -# name in tools. 
> -config XEN_PRIVILEGED_GUEST 
> - def_bool XEN_DOM0 
> - 
> config XEN_PVHVM 
> def_bool y 
> depends on XEN && PCI && X86_LOCAL_APIC 
> -- 
> 1.8.5.3 
>