linux-kernel - Re: [PATCH] Staging: comedi: kcomedilib: replace deprecated simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53020A12.1090607@mev.co.uk>
Date:	Mon, 17 Feb 2014 13:09:38 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Chase Southwood <chase.southwood@...oo.com>,
	gregkh@...uxfoundation.org
CC:	hsweeten@...ionengravers.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: kcomedilib: replace deprecated simple_strtoul()
 with kstrtouint()

On 2014-02-15 03:59, Chase Southwood wrote:
> Since simple_strtoul() has been deprecated, replace it with kstrtouint().
> Also, since return code checking for this new function is enforced, add a
> check to ensure that the conversion has succeeded.
>
> Signed-off-by: Chase Southwood <chase.southwood@...oo.com>
> ---
>   drivers/staging/comedi/kcomedilib/kcomedilib_main.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/kcomedilib/kcomedilib_main.c b/drivers/staging/comedi/kcomedilib/kcomedilib_main.c
> index 7dc5a18..8923e65 100644
> --- a/drivers/staging/comedi/kcomedilib/kcomedilib_main.c
> +++ b/drivers/staging/comedi/kcomedilib/kcomedilib_main.c
> @@ -41,7 +41,8 @@ struct comedi_device *comedi_open(const char *filename)
>   	if (strncmp(filename, "/dev/comedi", 11) != 0)
>   		return NULL;
>
> -	minor = simple_strtoul(filename + 11, NULL, 0);
> +	if (kstrtouint(filename + 11, 0, &minor))
> +		return NULL;
>
>   	if (minor >= COMEDI_NUM_BOARD_MINORS)
>   		return NULL;
>

Looks good!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/