linux-kernel - Re: [PATCH 4/4] Staging: comedi: addi-data: do not initialize statics to 0 in hwdrv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53020D1D.9020008@mev.co.uk>
Date:	Mon, 17 Feb 2014 13:22:37 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Chase Southwood <chase.southwood@...oo.com>,
	gregkh@...uxfoundation.org
CC:	hsweeten@...ionengravers.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] Staging: comedi: addi-data: do not initialize statics
 to 0 in hwdrv_apci035.c

On 2014-02-16 08:41, Chase Southwood wrote:
> This patch for hwdrv_apci035.c removes a zero initialization from two
> static variables.  Static variables are initialized to zero by default,
> so doing so explicitly is not necessary.
>
> Signed-off-by: Chase Southwood <chase.southwood@...oo.com>
> ---
> I purposely made this patch the last in the series, because while it is
> technically true that static variables need not be initialized to zero,
> and checkpatch doesn't much like the practice, I didn't know if, for
> readability's sake, you wanted these to stay in as-is. Since this is the
> last patch, feel free to drop it if you don't like it.
>
>   drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c
> index f02b714..10e02e5 100644
> --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c
> +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c
> @@ -106,8 +106,8 @@ static struct comedi_lrange range_apci035_ai = {
>   	}
>   };
>
> -static int i_WatchdogNbr = 0;
> -static int i_Temp = 0;
> +static int i_WatchdogNbr;
> +static int i_Temp;
>   static int i_Flag = 1;
>   /*
>   +----------------------------------------------------------------------------+
>

God knows why it's using these variables anyway.  The addi-data drivers 
that haven't been redone by Hartley are a complete mess!

FWIW, there's no extra harm in applying this patch!

Signed-off-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/