| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1392654243-2829-2-git-send-email-laijs@cn.fujitsu.com> Date: Tue, 18 Feb 2014 00:24:01 +0800 From: Lai Jiangshan <laijs@...fujitsu.com> To: Tejun Heo <tj@...nel.org> Cc: Lai Jiangshan <laijs@...fujitsu.com>, linux-kernel@...r.kernel.org Subject: [PATCH 1/3] workqueue: free worker earlier in worker_thread() When @worker is set %WORKER_DIE, it is moved out from idle_list&idr, no one can access it excepct kthread_data(). And in worker_thread, its task is clearred %PF_WQ_WORKER, no one can access the @worker via kthread_data(), we can safely free it. Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com> --- kernel/workqueue.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 783d5f2..fc05700 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -1862,7 +1862,6 @@ static void destroy_worker(struct worker *worker) kthread_stop(worker->task); put_task_struct(worker->task); - kfree(worker); spin_lock_irq(&pool->lock); } @@ -2297,6 +2296,8 @@ woke_up: spin_unlock_irq(&pool->lock); WARN_ON_ONCE(!list_empty(&worker->entry)); worker->task->flags &= ~PF_WQ_WORKER; + /* No one can access to @worker now, free it. */ + kfree(worker); return 0; } -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists