lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 17 Feb 2014 16:29:18 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...nel.org,
	laijs@...fujitsu.com, dipankar@...ibm.com,
	akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
	niv@...ibm.com, tglx@...utronix.de, peterz@...radead.org,
	rostedt@...dmis.org, dhowells@...hat.com, edumazet@...gle.com,
	darren@...art.com, fweisbec@...il.com, oleg@...hat.com, sbw@....edu
Subject: Re: [PATCH tip/core/rcu 21/55] rcutorture: Export torture_type and
 verbose module parameters

On Mon, Feb 17, 2014 at 02:12:25PM -0800, Paul E. McKenney wrote:
> From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
> 
> The torture_type and verbose module parameters are needed for log messages,
> so this commit exports them to include/linux/torture.h.
> 
> Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

Assuming this doesn't go away (which I really hope it does), this needs
to occur *before* the introduction of the macros using these variables.

- Josh Triplett

>  include/linux/torture.h | 4 ++++
>  kernel/rcu/rcutorture.c | 8 ++++++--
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/torture.h b/include/linux/torture.h
> index c61b4ce18a13..9b6a4834de8f 100644
> --- a/include/linux/torture.h
> +++ b/include/linux/torture.h
> @@ -49,6 +49,10 @@ extern int fullstop;
>  /* Protect fullstop transitions and spawning of kthreads.  */
>  extern struct mutex fullstop_mutex;
>  
> +/* Common module parameters. */
> +extern char *torture_type;
> +extern bool verbose;
> +
>  #define TORTURE_FLAG "-torture:"
>  #define TOROUT_STRING(s) \
>  	pr_alert("%s" TORTURE_FLAG s "\n", torture_type)
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index 3687619b243a..49cdeeaaa54b 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -90,11 +90,15 @@ torture_parm(int, test_boost_interval, 7,
>  	     "Interval between boost tests, seconds.");
>  torture_parm(bool, test_no_idle_hz, true,
>  	     "Test support for tickless idle CPUs");
> -torture_parm(bool, verbose, false, "Enable verbose debugging printk()s");
>  
> -static char *torture_type = "rcu";
> +char *torture_type = "rcu";
> +EXPORT_SYMBOL_GPL(torture_type);
>  module_param(torture_type, charp, 0444);
>  MODULE_PARM_DESC(torture_type, "Type of RCU to torture (rcu, rcu_bh, ...)");
> +bool verbose;
> +EXPORT_SYMBOL_GPL(verbose);
> +module_param(verbose, bool, 0444);
> +MODULE_PARM_DESC(verbose, "Enable verbose debugging printk()s");
>  
>  static int nrealreaders;
>  static struct task_struct *writer_task;
> -- 
> 1.8.1.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists