linux-kernel - Re: [PATCH 21/22] qla4xxx: Use pci_enable_msix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3FC4AB8B47ECD546BCD4B361A64BEACD8C64E701@avmb3.qlogic.org>
Date:	Tue, 18 Feb 2014 08:37:05 +0000
From:	Vikas Chaudhary <vikas.chaudhary@...gic.com>
To:	Alexander Gordeev <agordeev@...hat.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
CC:	Dept-Eng iSCSI Driver <Dept-iSCSIDriver@...gic.com>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-pci <linux-pci@...r.kernel.org>
Subject: Re: [PATCH 21/22] qla4xxx: Use pci_enable_msix_range()



On 04/02/14 3:17 AM, "Alexander Gordeev" <agordeev@...hat.com> wrote:

>As result of deprecation of MSI-X/MSI enablement functions
>pci_enable_msix() and pci_enable_msi_block() all drivers
>using these two interfaces need to be updated to use the
>new pci_enable_msi_range() and pci_enable_msix_range()
>interfaces.
>
>Signed-off-by: Alexander Gordeev <agordeev@...hat.com>
>Cc: Vikas Chaudhary <vikas.chaudhary@...gic.com>
>Cc: iscsi-driver@...gic.com
>Cc: linux-scsi@...r.kernel.org
>Cc: linux-pci@...r.kernel.org
>---
> drivers/scsi/qla4xxx/ql4_nx.c |    5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c
>index d001202..7f5412d 100644
>--- a/drivers/scsi/qla4xxx/ql4_nx.c
>+++ b/drivers/scsi/qla4xxx/ql4_nx.c
>@@ -3805,8 +3805,9 @@ qla4_8xxx_enable_msix(struct scsi_qla_host *ha)
> 	for (i = 0; i < QLA_MSIX_ENTRIES; i++)
> 		entries[i].entry = qla4_8xxx_msix_entries[i].entry;
> 
>-	ret = pci_enable_msix(ha->pdev, entries, ARRAY_SIZE(entries));
>-	if (ret) {
>+	ret = pci_enable_msix_range(ha->pdev, entries,
>+				    ARRAY_SIZE(entries), ARRAY_SIZE(entries));
>+	if (ret < 0) {
> 		ql4_printk(KERN_WARNING, ha,
> 		    "MSI-X: Failed to enable support -- %d/%d\n",
> 		    QLA_MSIX_ENTRIES, ret);

Looks good to me.
Acked-by: Vikas Chaudhary <vikas.chaudhary@...gic.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/