linux-kernel - Re: New bcache compiler warning (was: Re: bcache: Minor fixes from kbuild robot)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 18 Feb 2014 10:01:54 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Kent Overstreet <kmo@...erainc.com>
Cc:	Randy Dunlap <rdunlap@...radead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-bcache@...r.kernel.org
Subject: Re: New bcache compiler warning (was: Re: bcache: Minor fixes from
 kbuild robot)

On Mon, Feb 17, 2014 at 10:45 PM, Kent Overstreet <kmo@...erainc.com> wrote:
> *swears* Actually, I'm just going to cast this to unsigned (that's definitely
> safe here):
>
>
> commit 70bc49d421c793f73a772ae1f50622a39c6136d9
> Author: Kent Overstreet <kmo@...erainc.com>
> Date:   Mon Feb 17 13:44:06 2014 -0800
>
>     bcache: Fix another compiler warning on m68k

JFYI, you also get this warning on other 32-bit platforms (e.g. ARM).

>     Use a bigger hammer this time

Looks like it's big enough, now ;-)

>     Signed-off-by: Kent Overstreet <kmo@...erainc.com>
>
> diff --git a/drivers/md/bcache/bset.c b/drivers/md/bcache/bset.c
> index 3f74b4b074..5454164153 100644
> --- a/drivers/md/bcache/bset.c
> +++ b/drivers/md/bcache/bset.c
> @@ -23,8 +23,8 @@ void bch_dump_bset(struct btree_keys *b, struct bset *i, unsigned set)
>         for (k = i->start; k < bset_bkey_last(i); k = next) {
>                 next = bkey_next(k);
>
> -               printk(KERN_ERR "block %u key %li/%u: ", set,
> -                      (uint64_t *) k - i->d, i->keys);
> +               printk(KERN_ERR "block %u key %u/%u: ", set,
> +                      (unsigned) ((u64 *) k - i->d), i->keys);
>
>                 if (b->ops->key_dump)
>                         b->ops->key_dump(b, k);

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/