linux-kernel - Re: [alsa-devel] [PATCH 02/15] ASoC: dapm: Add locked version of snd_soc_dapm_xxxx_pin functions

Open Source and information security mailing list archives

Message-ID: <20140218090454.GA18502@opensource.wolfsonmicro.com>
Date:	Tue, 18 Feb 2014 09:04:54 +0000
From:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Lars-Peter Clausen <lars@...afoo.de>, alsa-devel@...a-project.org,
	patches@...nsource.wolfsonmicro.com, eric.y.miao@...il.com,
	dmitry.torokhov@...il.com, lgirdwood@...il.com,
	haojian.zhuang@...il.com, linux-kernel@...r.kernel.org,
	peter.ujfalusi@...com, cw00.choi@...sung.com,
	myungjoo.ham@...sung.com, linux@....linux.org.uk,
	jarkko.nikula@...mer.com
Subject: Re: [alsa-devel] [PATCH 02/15] ASoC: dapm: Add locked version of
	snd_soc_dapm_xxxx_pin functions

On Tue, Feb 18, 2014 at 09:30:30AM +0900, Mark Brown wrote:
> On Mon, Feb 17, 2014 at 06:06:03PM +0100, Lars-Peter Clausen wrote:
> 
> > Hm, this is a bit confusing. For other functions in ASoC when we
> > have a pair of functions with the _locked suffix and without the one
> > with _locked takes the lock, the other one doesn't. E.g.
> > snd_soc_update_bits_locked. Here we do it the other way around.
> 
> Yes, this is definitely confusing.  The existing naming might not be the
> best but making things inconsistent isn't going to help the situation
> either.

Oops... sorry that was not intentional I will respin to correct
this.

Thanks,
Charles

> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives