linux-kernel - Re: [PATCH net-next 10/35] enic: Use pci_enable_msix_range() instead of pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.03.1402181546150.11061@gmail.com>
Date:	Tue, 18 Feb 2014 15:48:02 +0530 (IST)
From:	Govindarajulu Varadarajan <govindarajulu90@...il.com>
To:	Alexander Gordeev <agordeev@...hat.com>
cc:	linux-kernel@...r.kernel.org,
	Christian Benvenuti <benve@...co.com>,
	Sujith Sankar <ssujith@...co.com>,
	Govindarajulu Varadarajan <govindarajulu90@...il.com>,
	Neel Patel <neepatel@...co.com>, netdev@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH net-next 10/35] enic: Use pci_enable_msix_range() instead
 of pci_enable_msix()



On Tue, 18 Feb 2014, Alexander Gordeev wrote:

> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() and pci_enable_msix_range()
> interfaces.
>
looks good, thanks

Acked-by: Govindarajulu Varadarajan <govindarajulu90@...il.com>



> Signed-off-by: Alexander Gordeev <agordeev@...hat.com>
> Cc: Christian Benvenuti <benve@...co.com>
> Cc: Sujith Sankar <ssujith@...co.com>
> Cc: Govindarajulu Varadarajan <govindarajulu90@...il.com>
> Cc: Neel Patel <neepatel@...co.com>
> Cc: netdev@...r.kernel.org
> Cc: linux-pci@...r.kernel.org
> ---
> drivers/net/ethernet/cisco/enic/enic_main.c |    6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
> index b740bfc..dcd58f2 100644
> --- a/drivers/net/ethernet/cisco/enic/enic_main.c
> +++ b/drivers/net/ethernet/cisco/enic/enic_main.c
> @@ -1796,7 +1796,8 @@ static int enic_set_intr_mode(struct enic *enic)
> 	    enic->cq_count >= n + m &&
> 	    enic->intr_count >= n + m + 2) {
>
> -		if (!pci_enable_msix(enic->pdev, enic->msix_entry, n + m + 2)) {
> +		if (pci_enable_msix_range(enic->pdev, enic->msix_entry,
> +					  n + m + 2, n + m + 2) > 0) {
>
> 			enic->rq_count = n;
> 			enic->wq_count = m;
> @@ -1815,7 +1816,8 @@ static int enic_set_intr_mode(struct enic *enic)
> 	    enic->wq_count >= m &&
> 	    enic->cq_count >= 1 + m &&
> 	    enic->intr_count >= 1 + m + 2) {
> -		if (!pci_enable_msix(enic->pdev, enic->msix_entry, 1 + m + 2)) {
> +		if (pci_enable_msix_range(enic->pdev, enic->msix_entry,
> +					  1 + m + 2, 1 + m + 2) > 0) {
>
> 			enic->rq_count = 1;
> 			enic->wq_count = m;
> -- 
> 1.7.7.6
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/