linux-kernel - Re: [PATCH] serial: 8250_pci: unbreak last serial ports on NetMos 9865 cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALT56yPj=0BTHxQ_2w+we8q4ETHjqX_VOUcbuYZBS5cU8GSooQ@mail.gmail.com>
Date:	Tue, 18 Feb 2014 15:00:36 +0400
From:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
To:	kernel list <linux-kernel@...r.kernel.org>,
	linux-serial@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] serial: 8250_pci: unbreak last serial ports on NetMos
 9865 cards

Hello,

On Tue, Feb 11, 2014 at 2:18 PM, Dmitry Eremin-Solenikov
<dbaryshkov@...il.com> wrote:
> Aparently 9865 uses standard BAR encoding scheme (unlike 99xx cards).
> Current pci_netmos_9900_setup() uses wrong BAR indices for the 9865 PCI
> device, function 2. Using standard BAR indices makes all 6 ports work
> for me. Thus disable the NetMos 9900 quirk for NetMos 9865 pci device.

Do you need any additional details for the patch?

[skipped lspci]

>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
> ---
>  drivers/tty/serial/8250/8250_pci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index 4697a51..143a381 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -784,7 +784,8 @@ static int pci_netmos_9900_setup(struct serial_private *priv,
>  {
>         unsigned int bar;
>
> -       if ((priv->dev->subsystem_device & 0xff00) == 0x3000) {
> +       if ((priv->dev->device != PCI_DEVICE_ID_NETMOS_9865) &&
> +           (priv->dev->subsystem_device & 0xff00) == 0x3000) {
>                 /* netmos apparently orders BARs by datasheet layout, so serial
>                  * ports get BARs 0 and 3 (or 1 and 4 for memmapped)
>                  */
> --
> 1.8.5.2
>



-- 
With best wishes
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/