linux-kernel - Re: [PATCH] staging: davinci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7270574.TJsfU1PaQa@avalon>
Date:	Tue, 18 Feb 2014 15:32:03 +0100
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Prabhakar Lad <prabhakar.csengg@...il.com>
Cc:	Josh Triplett <josh@...htriplett.org>,
	Levente Kurusa <levex@...ux.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux Media <linux-media@...r.kernel.org>,
	Lisa Nguyen <lisa@...apiadmin.com>,
	Archana kumari <archanakumari959@...il.com>,
	David Binderman <dcb314@...mail.com>
Subject: Re: [PATCH] staging: davinci_vpfe: fix error check

Hi Prabhakar,

(Removing Greg, Mauro and the devel@...verdev.osuosl.org list to avoid 
spamming them)

On Saturday 15 February 2014 09:16:19 Josh Triplett wrote:
> On Sat, Feb 15, 2014 at 11:17:11AM +0100, Levente Kurusa wrote:
> > The check would check the pointer, which is never less than 0.
> > According to the error message, the correct check would be
> > to check the return value of ipipe_mode. Check that instead.
> > 
> > Reported-by: David Binderman <dcb314@...mail.com>
> > Signed-off-by: Levente Kurusa <levex@...ux.com>
> 
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

Could you please handle this patch ?

> >  drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> > b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c index
> > 2d36b60..b2daf5e 100644
> > --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> > +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> > @@ -267,7 +267,7 @@ int config_ipipe_hw(struct vpfe_ipipe_device *ipipe)
> > 
> >  	}
> >  	
> >  	ipipe_mode = get_ipipe_mode(ipipe);
> > -	if (ipipe < 0) {
> > +	if (ipipe_mode < 0) {
> >  		pr_err("Failed to get ipipe mode");
> >  		return -EINVAL;
> >  	}

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/