linux-kernel - Re: [PATCH] w1-gpio: handle of_get_gpio() returning -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140218174727.GA14340@kroah.com>
Date:	Tue, 18 Feb 2014 09:47:27 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Evgeniy Polyakov <zbr@...emap.net>
Cc:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] w1-gpio: handle of_get_gpio() returning -EPROBE_DEFER
 better

On Tue, Feb 18, 2014 at 06:34:07PM +0400, Evgeniy Polyakov wrote:
> Hi
> 
> 18.02.2014, 12:24, "Uwe Kleine-König" <u.kleine-koenig@...gutronix.de>:
> 
> > The thing is that the w1-gpio device might be probed before the gpio's
> > controller is available. In this case of_get_gpio returns -EPROBE_DEFER
> > and this makes the device core retry probing the w1-gpio device later
> > again. So this is not a dt-parsing problem but just dependency stuff.
> >
> > The 2nd issue addressed didn't happen to me, but it might occur that the
> > first of_get_gpio for the data pin succeeds, but the getting the pullup
> > gpio fails with -EPROBE_DEFER (e.g. because it sits on a different
> > controller). In this case you still want to retry probing later instead
> > of ignoring the problem.
> >
> > Does that make it clearer?
> 
> Well, yes, thank you :)
> 
> Greg, please pull this patch into your tree.

Already merged :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/