linux-kernel - Re: [PATCH] Makefile: fix extra parenthesis typo when CC_STACKPROTECTOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJLy1X3_KYhAD+n80dYTRte3B=214k9PQvU8kBNCT=Y5w@mail.gmail.com>
Date:	Tue, 18 Feb 2014 10:26:49 -0800
From:	Kees Cook <keescook@...omium.org>
To:	Fathi Boudra <fathi.boudra@...aro.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Michal Marek <mmarek@...e.cz>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Makefile: fix extra parenthesis typo when
 CC_STACKPROTECTOR_REGULAR is enabled

On Mon, Feb 17, 2014 at 1:42 AM, Fathi Boudra <fathi.boudra@...aro.org> wrote:
> extra parenthesis typo introduced in commit 19952a9203 is causing
> the following error when CONFIG_CC_STACKPROTECTOR_REGULAR is enabled:
> Makefile:608: Cannot use CONFIG_CC_STACKPROTECTOR: -fstack-protector not
> supported by compiler
> Makefile:608: *** missing separator.  Stop.

Yikes! I have no idea how that snuck in. :( Thank you for noticing and
fixing this.

> Signed-off-by: Fathi Boudra <fathi.boudra@...aro.org>

Acked-by: Kees Cook <keescook@...omium.org>

Thanks!

-Kees

> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 893d6f0..eeaf3e7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -606,7 +606,7 @@ ifdef CONFIG_CC_STACKPROTECTOR_REGULAR
>    stackp-flag := -fstack-protector
>    ifeq ($(call cc-option, $(stackp-flag)),)
>      $(warning Cannot use CONFIG_CC_STACKPROTECTOR: \
> -             -fstack-protector not supported by compiler))
> +             -fstack-protector not supported by compiler)
>    endif
>  else ifdef CONFIG_CC_STACKPROTECTOR_STRONG
>    stackp-flag := -fstack-protector-strong
> --
> 1.8.1.2
>



-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/