linux-kernel - Re: [PATCH tip/core/rcu 15/55] rcutorture: Abstract rcu_torture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Feb 2014 16:22:48 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Josh Triplett <josh@...htriplett.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...nel.org,
	laijs@...fujitsu.com, dipankar@...ibm.com,
	akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
	niv@...ibm.com, tglx@...utronix.de, peterz@...radead.org,
	rostedt@...dmis.org, dhowells@...hat.com, edumazet@...gle.com,
	darren@...art.com, fweisbec@...il.com, oleg@...hat.com,
	sbw@....edu, linux@...izon.com
Subject: Re: [PATCH tip/core/rcu 15/55] rcutorture: Abstract
 rcu_torture_random()

On Mon, Feb 17, 2014 at 04:11:37PM -0800, Josh Triplett wrote:
> On Mon, Feb 17, 2014 at 02:12:19PM -0800, Paul E. McKenney wrote:
> > From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
> > 
> > Because rcu_torture_random() will be used by the locking equivalent to
> > rcutorture, pull it out into its own module.
> > 
> > Suggested-by: Rusty Russell <rusty@...tcorp.com.au>
> > Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> 
> I'd suggest making CONFIG_TORTURE_TEST a completely invisible option,
> with no description; it should only be brought in via "select".
> 
> Also, it doesn't need most of the headers it currently includes.
> 
> Have you considered moving it into the existing random generation
> infrastructure, as something like "fast_insecure_nonblocking_random"?
> That seems more generally useful.

George Spelvin was also advising me on random-number generation in
rcutorture, so I added him on CC.  In any case, I would not be adverse
to using some other random-number service, as long as it is fast enough.
(George suggested some optimizations that I have not yet tried out.)

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/