linux-kernel - Re: [PATCH] kernel/groups.c: remove return value of set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140218150346.ea6fc4fdb99ab24a4d77373f@linux-foundation.org>
Date:	Tue, 18 Feb 2014 15:03:46 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Wang YanQing <udknight@...il.com>
Cc:	ebiederm@...ssion.com, serge.hallyn@...onical.com,
	linux-kernel@...r.kernel.org, Eric Paris <eparis@...hat.com>
Subject: Re: [PATCH] kernel/groups.c: remove return value of set_groups

On Sun, 16 Feb 2014 23:31:07 +0800 Wang YanQing <udknight@...il.com> wrote:

> After commit 6307f8fee295b364716d28686df6e69c2fee751a
> ("security: remove dead hook task_setgroups"), set_groups
> will always return zero, so we could just remove return
> value of set_groups.
> 
> This patch reduce code size, and simplfy code logician
> to use set_groups, because we don't need to check its
> return value anymore.
> 

Looks OK.  We should also update the set_groups() description to
reflect reality.

--- a/kernel/groups.c~kernel-groupsc-remove-return-value-of-set_groups-fix
+++ a/kernel/groups.c
@@ -157,9 +157,6 @@ int groups_search(const struct group_inf
  * set_groups - Change a group subscription in a set of credentials
  * @new: The newly prepared set of credentials to alter
  * @group_info: The group list to install
- *
- * Validate a group subscription and, if valid, insert it into a set
- * of credentials.
  */
 void set_groups(struct cred *new, struct group_info *group_info)
 {
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/