linux-kernel - Re: [PATCH v2] of_mdio: fix phy interrupt passing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140218.181317.1712776234149210938.davem@davemloft.net>
Date:	Tue, 18 Feb 2014 18:13:17 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	grant.likely@...aro.org
Cc:	ben.dooks@...ethink.co.uk, linux-kernel@...ts.codethink.co.uk,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, linux-sh@...r.kernel.org,
	sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH v2] of_mdio: fix phy interrupt passing

From: Grant Likely <grant.likely@...aro.org>
Date: Tue, 18 Feb 2014 16:15:51 +0000

> On Tue, 18 Feb 2014 12:16:58 +0000, Ben Dooks <ben.dooks@...ethink.co.uk> wrote:
>> The of_mdiobus_register_phy() is not setting phy->irq thus causing
>> some drivers to incorrectly assume that the PHY does not have an
>> IRQ associated with it. Not only do some drivers report no IRQ
>> they do not install an interrupt handler for the PHY.
>> 
>> Simplify the code setting irq and set the phy->irq at the same
>> time so that we cover the following issues, which should cover
>> all the cases the code will find:
>> 
>> - Set phy->irq if node has irq property and mdio->irq is NULL
>> - Set phy->irq if node has no irq and mdio->irq is not NULL
>> - Leave phy->irq as PHY_POLL default if none of the above
>> 
>> This fixes the issue:
>>  net eth0: attached PHY 1 (IRQ -1) to driver Micrel KSZ8041RNLI
>> 
>> to the correct:
>>  net eth0: attached PHY 1 (IRQ 416) to driver Micrel KSZ8041RNLI
>> 
>> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> 
> Looks okay to me
> 
> Reviewed-by: Grant Likely <grant.likely@...aro.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/