linux-kernel - Re: [PATCH 1/2] staging: android: binder: remove unnecessary comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEjAshp2XE41idFaSgPtjHVj604QKJFfqydJtnJOu7grZhWLKQ@mail.gmail.com>
Date:	Wed, 19 Feb 2014 12:11:53 +0900
From:	SeongJae Park <sj38.park@...il.com>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Brian Swetland <swetland@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] staging: android: binder: remove unnecessary comment

On Wed, Feb 19, 2014 at 12:04 PM, Sachin Kamat <sachin.kamat@...aro.org> wrote:
> On 19 February 2014 05:58, SeongJae Park <sj38.park@...il.com> wrote:
>> On Wed, Feb 19, 2014 at 2:07 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
>>> On Tue, Feb 18, 2014 at 08:23:25PM +0900, SeongJae Park wrote:
>>>> Signed-off-by: SeongJae Park <sj38.park@...il.com>
>>>> ---
>>>>  drivers/staging/android/binder.c | 2 --
>>>>  1 file changed, 2 deletions(-)
>>>>
>>>> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
>>>> index eaec1da..b23cbc9 100644
>>>> --- a/drivers/staging/android/binder.c
>>>> +++ b/drivers/staging/android/binder.c
>>>> @@ -2553,8 +2553,6 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>>>>       unsigned int size = _IOC_SIZE(cmd);
>>>>       void __user *ubuf = (void __user *)arg;
>>>>
>>>> -     /*pr_info("binder_ioctl: %d:%d %x %lx\n", proc->pid, current->pid, cmd, arg);*/
>>>
>>> It's useful for debugging, I'll leave it as-is, sorry.
>
> Or just convert pr_info to pr_debug and leave uncommented?

Sounds much better. Thank you for suggestion.
I will send patch with your recommend again soon.

>
> --
> With warm regards,
> Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/