linux-kernel - Re: [PATCH] pfuze100-regulator: Fix of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Feb 2014 09:02:52 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Fabio Estevam <festevam@...il.com>
Cc:	Mark Brown <broonie@...nel.org>, Shawn Guo <shawn.guo@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] pfuze100-regulator: Fix of_node_get() parameter

On 19 February 2014 08:16, Fabio Estevam <festevam@...il.com> wrote:
> From: Fabio Estevam <fabio.estevam@...escale.com>
>
> Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get
> the following probe failure:
>
> pfuze100-regulator 1-0008: Full layer: 1, Metal layer: 0
> pfuze100-regulator 1-0008: FAB: 0, FIN: 0
> pfuze100-regulator 1-0008: regulators node not found
> pfuze100-regulator: probe of 1-0008 failed with error -22
>
> Now that of_get_child_by_name() is used we should adjust the device_node pointer
> 'np' to not get the parent node anymore.
>
> Suggested-by: Shawn Guo <shawn.guo@...aro.org>
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>

Thanks for the fix Fabio.
Acked-by: Sachin Kamat <sachin.kamat@...aro.org>

Mark,
There are a few more instances that should be fixed like this one. How would you
prefer to handle them - Resend the complete patch or send just the
incremental fix?

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/