linux-kernel - Re: mm: OS boot failed when set command-line kmemcheck=1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1402182344001.3551@chino.kir.corp.google.com>
Date:	Tue, 18 Feb 2014 23:49:42 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Xishi Qiu <qiuxishi@...wei.com>
cc:	Vegard Nossum <vegard.nossum@...il.com>,
	Linux MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: mm: OS boot failed when set command-line kmemcheck=1

On Wed, 19 Feb 2014, Xishi Qiu wrote:

> Hi all,
> 
> CONFIG_KMEMCHECK=y and set command-line "kmemcheck=1", I find OS 
> boot failed. The kernel is v3.14.0-rc3
> 
> If set "kmemcheck=1 nowatchdog", OS will boot successfully.
> 

I have automated kernel boots that have both "kmemcheck=0" and 
"kmemcheck=1" as the last parameter in the kernel command line every 
night and I've never seen it fail on tip or linux-next before.

So I'm sure I won't be able to reproduce your issue, but it may have 
something to do with your bootloader that isn't described above.  The 
sscanf() really wants to be replaced with kstrtoint().

Could you try this out?

diff --git a/arch/x86/mm/kmemcheck/kmemcheck.c b/arch/x86/mm/kmemcheck/kmemcheck.c
--- a/arch/x86/mm/kmemcheck/kmemcheck.c
+++ b/arch/x86/mm/kmemcheck/kmemcheck.c
@@ -78,10 +78,16 @@ early_initcall(kmemcheck_init);
  */
 static int __init param_kmemcheck(char *str)
 {
+	int val;
+	int ret;
+
 	if (!str)
 		return -EINVAL;
 
-	sscanf(str, "%d", &kmemcheck_enabled);
+	ret = kstrtoint(str, 0, &val);
+	if (ret)
+		return ret;
+	kmemcheck_enabled = val;
 	return 0;
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/