linux-kernel - Re: [PATCH 1/2] regulator: tps65218: Add terminate entry for of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140219050049.GE2669@sirena.org.uk>
Date:	Wed, 19 Feb 2014 14:00:49 +0900
From:	Mark Brown <broonie@...nel.org>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Keerthy <j-keerthy@...com>, Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] regulator: tps65218: Add terminate entry for
 of_device_id table

On Tue, Feb 18, 2014 at 08:20:59PM +0800, Axel Lin wrote:
> Fixes below build error:
> FATAL: drivers/regulator/tps65218-regulator: struct of_device_id is not terminated with a NULL entry!

This is good (though I'm not seeing a build time error myself...).

> Also remove of_match_ptr as this is a DT-only driver.

This should really have been split out as a separate change.  We
probably also need an OF dependency in the Kconfig for this (there may
be one on the MFD but having one here if the driver specficaly depends
on DT is better to avoid bisection issues if the MFD gets updated).

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)