lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Feb 2014 09:46:18 +0100 From: Peter Zijlstra <peterz@...radead.org> To: Steven Rostedt <rostedt@...dmis.org> Cc: Juri Lelli <juri.lelli@...il.com>, LKML <linux-kernel@...r.kernel.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Ingo Molnar <mingo@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [PATCH v3] sched/deadline: Fix bad accounting of nr_running On Tue, Feb 18, 2014 at 09:50:12PM -0500, Steven Rostedt wrote: > > > Rationale for this odd behavior is that, when a task is throttled, it > > is removed only from the dl_rq, but we keep it on_rq (as this is not > > a "full dequeue", that is the task is not actually sleeping). But, it > > is also true that, while throttled a task behaves like it is sleeping > > (e.g., its timer will fire on a new CPU if the old one is dead). So, > > Steven's fix sounds also semantically correct. > > Actually, it seems that I was hitting it again, but this time getting a > negative number. OK, after looking at the code a bit more, I think we > should update the runqueue nr_running only when the task is officially > enqueued and dequeued, and all accounting within, will not touch that > number. But if the task is throttled it should still very much decrement the number. There's places that very much rely on nr_running be exactly the number of runnable tasks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists