linux-kernel - Re: Does it need to implement irq_set_type method in the ioapic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e7b7684-2f67-4dca-b889-94b942cc72dd@email.android.com>
Date:	Wed, 19 Feb 2014 05:28:15 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Thomas Gleixner <tglx@...utronix.de>,
	carl peng <carlpeng008@...il.com>
CC:	mingo@...hat.com, x86@...nel.org, pingfank@...ux.vnet.ibm.com,
	yoshihiro.yunomae.ez@...achi.com, linux-kernel@...r.kernel.org
Subject: Re: Does it need to implement irq_set_type method in the ioapic_chip?

In the casee of your ACPI-enabled AMBA device I believe the BIOS, which provides the ACPI tables, is expected to set the interrupt type.

On February 19, 2014 4:07:09 AM PST, Thomas Gleixner <tglx@...utronix.de> wrote:
>On Wed, 19 Feb 2014, carl peng wrote:
>> At last, the device will be connected to AMBA bus, so the interrupt
>> pin will be connected to IOAPIC through AMBA bus. The device now
>> is in the pre-silicon verification stage.
>> 
>> So my question is the same:
>> Why does APIC driver not implement the irq_set_type method?  if
>
>Because we do not need it. All devices are properly connected and
>configured by the BIOS and bus discovery.
>
>> implement it, will supply more free space for the device driver
>> developer(they can set the interrupttrigger mode by calling
>request_irq).
>
>There are 3 different mechanisms already to tell the kernel to
>configure a particular irq line: ACPI, MP Tables and SFI.
>
>That's the way x86 does its interrupt configuration and there is no
>need to provide another one.
>
>Thanks,
>
>	tglx

-- 
Sent from my mobile phone.  Please pardon brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/