linux-kernel - Re: [Linaro-acpi] [PATCH v4 5/5] ACPI: Replace printk with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Feb 2014 17:49:35 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Sudeep Holla <Sudeep.Holla@....com>
Cc:	Hanjun Guo <hanjun.guo@...aro.org>,
	Lan Tianyu <tianyu.lan@...el.com>,
	"linaro-acpi@...ts.linaro.org" <linaro-acpi@...ts.linaro.org>,
	"patches@...aro.org" <patches@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [Linaro-acpi] [PATCH v4 5/5] ACPI: Replace printk with pr_* in tables.c

On Wednesday, February 19, 2014 04:32:34 PM Sudeep Holla wrote:
> On 18/02/14 13:55, Hanjun Guo wrote:
> > This patch just do some clean up to replace printk with pr_*,
> > no functional change.
> > 
> Any particular reason for choosing just this file in this series ?
> It seems but off-topic in this series. The printk format is same in almost all
> other acpi files and it's better to change all or none for consistency.

Well, it's fine, I can put it into a different branch in any case. :-)

> > Signed-off-by: Hanjun Guo <hanjun.guo@...aro.org>
> > ---
> >  drivers/acpi/tables.c |   51 +++++++++++++++++++------------------------------
> >  1 file changed, 20 insertions(+), 31 deletions(-)
> > 
> > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> > index 5837f85..97bc6df 100644
> > --- a/drivers/acpi/tables.c
> > +++ b/drivers/acpi/tables.c
> > @@ -55,8 +55,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
> >  		{
> >  			struct acpi_madt_local_apic *p =
> >  			    (struct acpi_madt_local_apic *)header;
> > -			printk(KERN_INFO PREFIX
> > -			       "LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n",
> > +			pr_info(PREFIX "LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n",
> 
> You can even get rid of PREFIX by defining pr_fmt instead.

But this is a good point.

> If the intention is to move to pr_* format it's better to have this as separate
> patch and convert all of them.

Well, not really.  One file at a time is OK too.

Thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/